search

getsentry / sentry-dotnet

Sentry SDK for .NET
https://docs.sentry.io/platforms/dotnet
MIT License
566 stars 203 forks source link

Fix BackgroundWorker exiting when OperationCanceledException is not from shutdown request #3284

Closed phillipcaofph closed 3 weeks ago

phillipcaofph commented 1 month ago

Fixes https://github.com/getsentry/sentry-dotnet/issues/3274

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.95%. Comparing base (495e742) to head (44f1721). Report is 102 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3284 +/- ## ========================================== + Coverage 75.73% 76.95% +1.22% ========================================== Files 357 371 +14 Lines 13466 13898 +432 Branches 2671 2754 +83 ========================================== + Hits 10198 10695 +497 + Misses 2593 2503 -90 - Partials 675 700 +25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bitsandfoxes commented 1 month ago

Hey @phillipcaofph, thanks for contributing! The change absolutely makes sense and I'd love to merge this but we first need to figure out the testing situation as it touches some very internal bits. Thanks for your patience.