search

getsentry / sentry-dotnet

Sentry SDK for .NET
https://docs.sentry.io/platforms/dotnet
MIT License
582 stars 207 forks source link

Flaky Profiling Tests #3637

Open bitsandfoxes opened 1 week ago

bitsandfoxes commented 1 week ago

I'm skipping the test Profiler_ThrowingOnSessionStartup_DoesntBreakSentryInit here: https://github.com/getsentry/sentry-dotnet/pull/3635/files

We should re-enable it.

jamescrosswell commented 5 days ago

We should re-enable it.

I'm not sure we should, unless we can make it more reliable. It fails all the time and we just rerun the tests until it passes. What's the point in the test in that case?

bitsandfoxes commented 4 days ago

Bad phrasing. You're correct. They should be made "not flaky". What's the point of flaky tests.