fix: Android - make sure logcat.log is attached to unhandled event (SIGSEGV Segfault)

getsentry / sentry-dotnet

Sentry SDK for .NET

https://docs.sentry.io/platforms/dotnet

MIT License

604 stars 206 forks source link

fix: Android - make sure logcat.log is attached to unhandled event (SIGSEGV Segfault) #3694

Open bricefriha opened 1 month ago

bricefriha commented 1 month ago

From sentry-native#1027, we had to add the handler strategy to the .NET SDK, from the sentry-java (7.15.0-alpha1).

This is also meant to fix #3461. I tested this, and it seems to be fixed now.

More context at:

https://github.com/dotnet/android/issues/9055#issuecomment-2261347912

Note

These changes seem to require a -alpha release

bricefriha commented 1 month ago

@jamescrosswell it seems like the wrong version of the Java SDK is set there. Which causes the CI to crash.

Is there a way to set this version to 7.15.0-alpha.1 without updating Sentry.Bindings.Android.csproj?

jamescrosswell commented 1 month ago

Is there a way to set this version to 7.15.0-alpha.1 without updating Sentry.Bindings.Android.csproj

I think we do want to update the Sentry.Bindings.Android.csproj right? How would we be using the new Native functionality otherwise?

jamescrosswell commented 4 weeks ago

Requested this release that we can share with testers.

bruno-garcia commented 3 weeks ago

Note: https://github.com/getsentry/publish/issues/4545#issuecomment-2452007323

bruno-garcia commented 3 weeks ago

which issue to reach out for feedback? anyone trying this out to help validate?

jamescrosswell commented 3 weeks ago

which issue to reach out for feedback? anyone trying this out to help validate?

See comment:

https://github.com/getsentry/sentry-dotnet/issues/3461#issuecomment-2453766597

bricefriha commented 3 weeks ago

anyone trying this out to help validate?

@bruno-garcia @jamescrosswell I created a repo to test this alpha release and it works perfectly https://github.com/bricefriha/Sentry-3694

bruno-garcia commented 3 weeks ago

anyone trying this out to help validate?

@bruno-garcia @jamescrosswell I created a repo to test this alpha release and it works perfectly bricefriha/Sentry-3694

Awesome! thank you for that. Shoudl we merge?

bricefriha commented 3 weeks ago

Shoudl we merge?

We could, but the issue is that we need to use the Android SDK version 7.15.0-alpha.1 until the NDKHandler setting is available on the full release. So shouldn't we wait for that first?

bruno-garcia commented 3 weeks ago

Shoudl we merge?

We could, but the issue is that we need to use the Android SDK version 7.15.0-alpha.1 until the NDKHandler setting is available on the full release. So shouldn't we wait for that first?

If it's validated, we should reach out to folks on Android to merge that to main and ship a new release.

We can merge ours (after bumping to that version) then.

Also: Should that option be the new default? So users don't need to do anything?

bricefriha commented 3 weeks ago

We can merge ours (after bumping to that version) then.

sounds good

Should that option be the new default? So users don't need to do anything?

yes it is, so basically users don't need to change anything at all

bruno-garcia commented 1 week ago

What's the next steps for this?

bricefriha commented 1 week ago

What's the next steps for this?

I let the Java team know that we are ready to merge so they are working on merging their PRs as well

once they have the update on the main release, we can merge

bruno-garcia commented 1 week ago

merged! https://github.com/getsentry/sentry-native/pull/1027#event-15314896031

We'd like to wait for their release though, so we can checkout the release tag instead of a random commit sha

bricefriha commented 1 week ago

We'd like to wait for their release though

The release is out now! https://github.com/getsentry/sentry-native/releases/tag/0.7.13

We just need an update from sentry-java