Review Android AssemblyReader - Githubissues

getsentry / sentry-dotnet

Sentry SDK for .NET

https://docs.sentry.io/platforms/dotnet

MIT License

598 stars 207 forks source link

Review Android AssemblyReader #3761

Open bruno-garcia opened 4 hours ago

bruno-garcia commented 4 hours ago

Came up on Discord:

Our current version of Android AssemblyReader was taken from this sha:

https://github.com/getsentry/sentry-dotnet/blob/cbe1af4c722b22eb6ee0cbe5c70b25a8d7056d41/src/Sentry.Android.AssemblyReader/ATTRIBUTION.txt#L2

Upstream, as the history shows:

https://github.com/dotnet/android/commits/main/tools/assembly-store-reader/AssemblyStoreExplorer.cs

A change was done to it since:

https://github.com/dotnet/android/pull/8694/files#diff-d705beccc7479fb87d9203224767b0bd417e49e3b8de238ec0cd0811179d1de6

I didn't look into it but might be related to making assemblies RID specific, changing the internal layout of the apk:

https://github.com/dotnet/android/pull/8478

bruno-garcia commented 4 hours ago

@jamescrosswell @bricefriha one way to test if things are working, is getting a Release built Android app built on .NET 9, and see if we still get all C# line numbers in exceptions and crashes