search

getsentry / sentry-elixir

The official Elixir SDK for Sentry (sentry.io)
https://sentry.io
MIT License
622 stars 183 forks source link

Switch from Hackney to Finch as the default HTTP client #724

Open whatyouhide opened 4 months ago

whatyouhide commented 4 months ago

Finch is really reliable and fast, and has significantly less dependencies than Hackney. It also exposes Telemetry events, whereas Hackney doesn't.

I think it would be nice to switch to it as the default client. We can leave Sentry.HackneyClient around for people that prefer it.

Thoughts @sl0thentr0py?

sl0thentr0py commented 4 months ago

yep sure if you think that's better, go for it!

savhappy commented 2 months ago

@whatyouhide should we have a flag that can be flipped to use Hackney instead of Finch after Finch is set as default? And apply this flag to the supervision tree upon start?

whatyouhide commented 2 months ago

No it's not necessary. We can just switch to Finch. If users want to use Hackney, they can write an adapter—maybe we can just put the Hackney Sentry client we have now in the codebase over into the docs if they want to copypaste that.

savhappy commented 1 month ago

PR out for this switch-a-roo @whatyouhide ^_^