search

getsentry / sentry-godot-hackweek-2022

12 stars 2 forks source link

Godot first class support #1

Open bruno-garcia opened 7 months ago

bruno-garcia commented 7 months ago

Some changes possibly landing on Godot would help a first class SDK:

Also worth sharing some comments in tickets from ppl trying to get the Sentry SDK for .NET into Godot, so a first class support here as we have for Unity would be awesome:

farfalk commented 5 months ago

Hey there! Small update: https://github.com/godotengine/godot/pull/87576 is getting to the final round of checks before merge.

If there's anything (small) you'd like to get inside of it, that would make implementation on your side easier, this is probably the last chance! 😄

If there's something bigger, of course your comments would be appreciated all the same: simply, instead of being considered for this PR, they could spawn other related PRs that will be considered in the future.

bruno-garcia commented 5 months ago

Thanks for the heads up!

@bitsandfoxes maybe something you have bandwidth to collaborate with folks?

bruno-garcia commented 5 months ago

@farfalk

If the error is caused by a C# exception, and you're setting a callback in C#, then this doesn't provide access to the actual C# exception object. It could! I don't personally need this functionality but it's a pretty obvious thing to add later if there's demand.

Sentry to be able to integrate properly would need the instance of the exception. So we can, for example, get the right metadata in order to server-side, find debug symbols and look up line numbers and paths. For example.

bruno-garcia commented 4 months ago

In 2022 I asked about hooks to the logging functions but no luck: https://forum.godotengine.org/t/how-can-i-listen-to-call-made-to-gd-pusherror-gd-pushwarning-gd-print/8024