Plugin Deinstallation can Leave Tenant Behind

getsentry / sentry-hipchat-ac

New hipchat API.

Apache License 2.0

11 stars 5 forks source link

Plugin Deinstallation can Leave Tenant Behind #11

Closed mitsuhiko closed 9 years ago

mitsuhiko commented 9 years ago

I sometimes see tenants left behind. Presumably this is from uninstalling the plugin through some flow. We should figure out when that happens and make it more robust.

dcramer commented 9 years ago

I clicked disable on sentry's side at one point and it didnt seem to entirely disconnect everything on both sides.

mitsuhiko commented 9 years ago

If you disable on the sentry side we only delete the project associations. There is (as far as I know) no way to remove the integration on the hipchat side.

mitsuhiko commented 9 years ago

i thought i have guarded against that by deleting a tenant with the old
oauth key forcefully if it's already there

[00:52] armin: but apparently that does not fix it in all situations

[00:52] armin: not sure what the right fix is, but i added an issue for it

[00:52] armin: i assume their webhook sometimes can fail

[00:52] armin: it fixes itself if you re-add the plugin to the broken room

[00:52] armin: and then delete it :stuck_out_tongue:
NEW MESSAGES