getsentry / sentry-infra-tools

An attempt to move senytry-kube to its own repository
1 stars 0 forks source link

feat(tests): Make all existing tests pass #7

Closed nikhars closed 1 month ago

nikhars commented 1 month ago

Output of tests

 ~/w/sentry-kube  nikhars/feat/default-config !1 ?1  make tools-test
 ok | direnv  3.11.6 py  11:46:20
pytest -vv .
================================================================================= test session starts =================================================================================
platform darwin -- Python 3.11.6, pytest-8.2.2, pluggy-1.5.0 -- /Users/nikharsaxena/workspace/sentry-kube/.venv/bin/python3
cachedir: .pytest_cache
rootdir: /Users/nikharsaxena/workspace/sentry-kube
configfile: pyproject.toml
plugins: anyio-4.4.0, xdist-3.6.1
collected 78 items

assistant/test_prdocs.py::test_empty PASSED                                                                                                                                     [  1%]
assistant/test_prdocs.py::test_full_message PASSED                                                                                                                              [  2%]
config_builder/merger/test_libsonnet.py::test_order PASSED                                                                                                                      [  3%]
config_builder/merger/test_yaml.py::test_merger PASSED                                                                                                                          [  5%]
config_builder/test_combined_generator.py::test_generated_libsonnet_file_content PASSED                                                                                         [  6%]
config_builder/test_combined_generator.py::test_generated_json_content PASSED                                                                                                   [  7%]
config_builder/test_combined_generator.py::test_iteration PASSED                                                                                                                [  8%]
config_builder/test_combined_generator.py::test_combine_all[Combining libsonnet files] PASSED                                                                                   [ 10%]
config_builder/test_combined_generator.py::test_combine_all[Combining yaml files] PASSED                                                                                        [ 11%]
config_builder/test_combined_generator.py::test_cleanup PASSED                                                                                                                  [ 12%]
config_builder/test_json_schema_validator.py::test_json_schema_validator[Validate valid yaml file (regional override)] PASSED                                                   [ 14%]
config_builder/test_json_schema_validator.py::test_json_schema_validator[Validate valid yaml file (default consumer group)] PASSED                                              [ 15%]
config_builder/test_json_schema_validator.py::test_json_schema_validator[Unrelated directory should not be validated] PASSED                                                    [ 16%]
config_builder/test_json_schema_validator.py::test_json_schema_validator[Unrelated subdirectory should not be validated] PASSED                                                 [ 17%]
config_builder/test_json_schema_validator.py::test_json_schema_invalid[Invalid yaml file should fail correctly (wrong type in ref)] PASSED                                      [ 19%]
config_builder/test_json_schema_validator.py::test_json_schema_invalid[Invalid yaml file should fail correctly (extra key)] PASSED                                              [ 20%]
config_builder/test_json_schema_validator.py::test_json_schema_invalid[Invalid yaml file should fail correctly (missing required)] PASSED                                       [ 21%]
config_builder/test_materializer.py::test_iteration PASSED                                                                                                                      [ 23%]
config_builder/test_materializer.py::test_materialize_file[Put the materialized file in an arbitrary directory0] PASSED                                                         [ 24%]
config_builder/test_materializer.py::test_materialize_file[Put the materialized file in an arbitrary directory1] PASSED                                                         [ 25%]
config_builder/test_materializer.py::test_materialize_file[Yaml file] PASSED                                                                                                    [ 26%]
libsentrykube/tests/kubectl/test_important_diffs.py::test_process_data PASSED                                                                                                   [ 28%]
libsentrykube/tests/test_cluster.py::test_clusters_load[Load cluster template] PASSED                                                                                           [ 29%]
libsentrykube/tests/test_cluster.py::test_fail_load PASSED                                                                                                                      [ 30%]
libsentrykube/tests/test_cluster.py::test_list_clusters PASSED                                                                                                                  [ 32%]
libsentrykube/tests/test_cluster.py::test_list_clusters_for_customer PASSED                                                                                                     [ 33%]
libsentrykube/tests/test_config.py::test_config_load PASSED                                                                                                                     [ 34%]
libsentrykube/tests/test_context.py::test_init PASSED                                                                                                                           [ 35%]
libsentrykube/tests/test_customer.py::test_config_load PASSED                                                                                                                   [ 37%]
libsentrykube/tests/test_datadog.py::test_check_monitor_ok PASSED                                                                                                               [ 38%]
libsentrykube/tests/test_datadog.py::test_check_monitor_missing_overall_state PASSED                                                                                            [ 39%]
libsentrykube/tests/test_datadog.py::test_check_monitor_bad_http_response PASSED                                                                                                [ 41%]
libsentrykube/tests/test_deep_merge.py::test_basic_merge PASSED                                                                                                                 [ 42%]
libsentrykube/tests/test_deep_merge.py::test_extra_keys_into PASSED                                                                                                             [ 43%]
libsentrykube/tests/test_deep_merge.py::test_extra_keys_other PASSED                                                                                                            [ 44%]
libsentrykube/tests/test_deep_merge.py::test_basic_no_overwrite PASSED                                                                                                          [ 46%]
libsentrykube/tests/test_deep_merge.py::test_deep_merge_double_dict_with_overwrite PASSED                                                                                       [ 47%]
libsentrykube/tests/test_deep_merge.py::test_deep_merge_double_dict_no_overwrite PASSED                                                                                         [ 48%]
libsentrykube/tests/test_gcloud.py::test_get_channel_versions_success PASSED                                                                                                    [ 50%]
libsentrykube/tests/test_gcloud.py::test_get_channel_versions_bad_response PASSED                                                                                               [ 51%]
libsentrykube/tests/test_jira.py::test_create_issue_success PASSED                                                                                                              [ 52%]
libsentrykube/tests/test_jira.py::test_create_issue_failure PASSED                                                                                                              [ 53%]
libsentrykube/tests/test_jira.py::test_update_ticket_success PASSED                                                                                                             [ 55%]
libsentrykube/tests/test_jira.py::test_update_ticket_failure PASSED                                                                                                             [ 56%]
libsentrykube/tests/test_jira.py::test_find_jira_issue_success PASSED                                                                                                           [ 57%]
libsentrykube/tests/test_jira.py::test_find_jira_issue_not_found PASSED                                                                                                         [ 58%]
libsentrykube/tests/test_jira.py::test_find_jira_issue_failure PASSED                                                                                                           [ 60%]
libsentrykube/tests/test_jira.py::test_create_comment_success PASSED                                                                                                            [ 61%]
libsentrykube/tests/test_jira.py::test_create_comment_failure PASSED                                                                                                            [ 62%]
libsentrykube/tests/test_lint.py::test_lint PASSED                                                                                                                              [ 64%]
libsentrykube/tests/test_lint.py::test_kubelinter_config PASSED                                                                                                                 [ 65%]
libsentrykube/tests/test_lint.py::test_kubelinter_config_file_cluster PASSED                                                                                                    [ 66%]
libsentrykube/tests/test_reversemap.py::test_trie[Empty trie] PASSED                                                                                                            [ 67%]
libsentrykube/tests/test_reversemap.py::test_trie[Path outside of the trie] PASSED                                                                                              [ 69%]
libsentrykube/tests/test_reversemap.py::test_trie[Incomplete path] PASSED                                                                                                       [ 70%]
libsentrykube/tests/test_reversemap.py::test_trie[Contains exact path] PASSED                                                                                                   [ 71%]
libsentrykube/tests/test_reversemap.py::test_trie[Contains subpath] PASSED                                                                                                      [ 73%]
libsentrykube/tests/test_reversemap.py::test_trie[Incomplete path - multiple levels] PASSED                                                                                     [ 74%]
libsentrykube/tests/test_reversemap.py::test_trie[Multi level, subpath present] PASSED                                                                                          [ 75%]
libsentrykube/tests/test_reversemap.py::test_trie[Multi level, exact path] PASSED                                                                                               [ 76%]
libsentrykube/tests/test_reversemap.py::test_resource_index[One existing service in one cluster] PASSED                                                                         [ 78%]
libsentrykube/tests/test_reversemap.py::test_resource_index[One existing service in four clusters] PASSED                                                                       [ 79%]
libsentrykube/tests/test_reversemap.py::test_resource_index[One existing service in four clusters, exact path] PASSED                                                           [ 80%]
libsentrykube/tests/test_reversemap.py::test_resource_index[One symlinked service in multiple clusters] PASSED                                                                  [ 82%]
libsentrykube/tests/test_reversemap.py::test_merge_references PASSED                                                                                                            [ 83%]
pr_approver/test_approver.py::test_approver PASSED                                                                                                                              [ 84%]
pr_approver/test_rules.py::test_decision[Same value in same value out] PASSED                                                                                                   [ 85%]
pr_approver/test_rules.py::test_decision[Approve wins over Ignore] PASSED                                                                                                       [ 87%]
pr_approver/test_rules.py::test_decision[Decline wins over Ignore] PASSED                                                                                                       [ 88%]
pr_approver/test_rules.py::test_decision[Decline wins over Approve] PASSED                                                                                                      [ 89%]
pr_approver/test_rules.py::test_approval[Adding services does not require review] PASSED                                                                                        [ 91%]
pr_approver/test_rules.py::test_approval[Removing tier 0 service requires review] PASSED                                                                                        [ 92%]
pr_approver/test_rules.py::test_approval[Removing tier 3 service does not require review] PASSED                                                                                [ 93%]
pr_approver/test_rules.py::test_approval[Bumping up tier requires review] PASSED                                                                                                [ 94%]
pr_approver/test_rules.py::test_approval[Abandoning service requires review] PASSED                                                                                             [ 96%]
pr_approver/test_rules.py::test_approval[Removing one team without abandoning service does not require review] PASSED                                                           [ 97%]
pr_approver/test_rules.py::test_approval[Removing slack channel requires review] PASSED                                                                                         [ 98%]
pr_approver/test_rules.py::test_approval[Changing name does not require review] PASSED                                                                                          [100%]

================================================================================= 78 passed in 0.89s ==================================================================================
nikhars commented 1 month ago

I am merging this for now since the github job I am writing depends on this. Please leave any comments you have. I can address them in a later PR