getsentry / sentry-java

A Sentry SDK for Java, Android and other JVM languages.
https://docs.sentry.io/
MIT License
1.15k stars 434 forks source link

Split out ReactorUtils and required classes from Spring integration #3144

Open Angelodaniel opened 8 months ago

Angelodaniel commented 8 months ago

Problem Statement

We already have support for reactor in our Spring integration as part of the WebFlux specifics. Users who are not using Spring would also like to use e.g. ReactorUtils so they don't have to deal with Hub propagation themselves.

Solution Brainstorm

To consider:

Do we want to always bring this new module as a dependency for Spring or do we want to rely on our build plugins to automatically add it and code it in a way where it has to be added manually as a dependency by the user when not using our build plugin auto install feature?

Probably not worth it to make it an optional dependency if it doesn't have any dependencies of its own as it just creates a pitfall.

┆Issue is synchronized with this Jira Improvement by Unito

Angelodaniel commented 8 months ago

Customer mitigated the problem by copying the functionality. So I would say this is low prio @adinauer

kahest commented 8 months ago

Thanks for the update/workaround @Angelodaniel

adinauer commented 8 months ago

Thanks @Angelodaniel I've reduce prio a bit but still think we should do this as it's not a lot of work and can help some users running into the same problem.