getsentry / sentry-java

A Sentry SDK for Java, Android and other JVM languages.
https://docs.sentry.io/
MIT License
1.16k stars 435 forks source link

RuntimeException in io.sentry.graphql.SentryInstrumentation #3341

Open kahest opened 6 months ago

kahest commented 6 months ago

Description

RuntimeException in io.sentry.graphql.SentryInstrumentation in lambda$instrumentExecutionResult$0 at line 208

Affected packages and versions:

Internal references:

adinauer commented 6 months ago

While this might also report SDK bugs, it's most likely just an error going out through GraphQL errors.

It's being detected as a crash because the integration creates the RuntimeException as there's no throwable to wrap but just a message. We should ignore the exception for crash detection.

There's multiple things we could use to ignore it:

Most likely B is what we want. The name of the function might change but that shouldn't happen often - we should document this next to the function. For existing releases of the SDK we'll have to ignore as mentioned above. Where we create the exception should probably be separated out into each own function so it's even less likely to change over time then ignore whatever the name is.