search

getsentry / sentry-java

A Sentry SDK for Java, Android and other JVM languages.
https://docs.sentry.io/
MIT License
1.14k stars 432 forks source link

Android manifest int/float parsing #3603

Open vaind opened 1 month ago

vaind commented 1 month ago

Integration

sentry-android

Build System

Gradle

AGP Version

n/a

Proguard

Enabled

Version

7.12.0

Steps to Reproduce

Add <meta-data android:name="io.sentry.session-replay.session-sample-rate" android:value="1" /> to android manifest (this is what was output by a custom tooling that creates items programatically during build from a 1.0 double value after calling ToString() on it in c#

Expected Result

Recognizes 1 as 1.0

Actual Result

Key io.sentry.session-replay.session-sample-rate expected Float but value was a java.lang.Integer. The default value -1.0 was returned.

markushi commented 1 month ago

@vaind thanks for reporting! Let's ensure we fix this for all attributes where we expect float values.