Add Profiles to Custom Transactions

[thinkocapo]

Integration

sentry-android

Build System

Gradle

AGP Version

4.11.0

Proguard

Enabled

Version

7.14.0

Steps to Reproduce

Hi I have profiling enabled and created a Custom Transaction but there's no associated profile. demo app creates a custom transaction here and I don't see a Profile appear with it (trace) by default, and we have Profiling enabled.

Documentation mentions how to add spans, connect errors and do other things with Custom Instrumentation but no mention on profiling. Is it possible?

https://docs.sentry.io/platforms/android/tracing/instrumentation/custom-instrumentation/

Customer I'm working with is going to do this for their iOS app too.

Documentation Request https://github.com/getsentry/sentry-docs

Solution Idea

A good solution would not involve having to do something like profile.start() and then set it on scope of the transaction/span object. It'd be nice to have it recording...as soon as you start the new transaction/span.

1. start a custom transaction [docs say transaction, not span]
2. profile starts being recorded (assuming they have SDK Profiling enabled)
3. end the custom transaction and this ends the profile

Expected Result

Custom Transaction with a Profile

Actual Result

Custom Transaction with no Profile

[kahest]

Just noting that this should work ootb and we're analysing if/why this might not work as expected in these cases.

[markushi]

Let's give this a quick test, but by using a profiler callback this should work fine.

[markushi]

As discussed internally: You can use profilesSampler to control which transactions get profiled and which not, more details are on our docs page.

Closing this for now, @thinkocapo please let us know if there's still an issue and we'll re-open!