Fix standalone tomcat jndi issue

getsentry / sentry-java

A Sentry SDK for Java, Android and other JVM languages.

MIT License

1.16k stars 435 forks source link

:scroll: Description

Rename getParsedDsn() to retrieveParsedDsn() to fix issue with JNDI property binding. This caused getParsedDsn() to be called prematurely and lead to crashes with an emtpy Dsn.

:bulb: Motivation and Context

Fixes #3825

:green_heart: How did you test it?

:pencil: Checklist

[ ] I reviewed the submitted code.
[ ] I added tests to verify the changes.
[ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
[ ] I updated the docs if needed.
[ ] Review from the native team if needed.
[ ] No breaking change or entry added to the changelog.
[ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.

:crystal_ball: Next steps

Performance metrics :rocket:

	Plain	With Sentry	Diff
Startup time	418.08 ms	448.08 ms	30.00 ms
Size	1.70 MiB	2.35 MiB	668.45 KiB

Plain

With Sentry

Diff

Startup time

418.08 ms

448.08 ms

30.00 ms

Size

1.70 MiB

2.35 MiB

668.45 KiB

Previous results on branch: fix/spring-boot-tomcat-dsn

Startup times

Revision	Plain	With Sentry	Diff
661a781c2b0880548b3a9aa7dba70c78914b7025	478.29 ms	547.36 ms	69.07 ms
83d667559201cbb4fec2ff42bc7e53e77f6fd070	435.51 ms	453.35 ms	17.84 ms

App size

Revision	Plain	With Sentry	Diff
661a781c2b0880548b3a9aa7dba70c78914b7025	1.70 MiB	2.35 MiB	668.45 KiB
83d667559201cbb4fec2ff42bc7e53e77f6fd070	1.70 MiB	2.35 MiB	668.45 KiB