Raise warning if `release` passed in is not an object

getsentry / sentry-javascript-bundler-plugins

JavaScript Bundler Plugins for Sentry

https://sentry.io

BSD 3-Clause "New" or "Revised" License

142 stars 37 forks source link

Raise warning if `release` passed in is not an object #455

Open HazAT opened 11 months ago

HazAT commented 11 months ago

When using the Vite Plugin to inject Debug IDs and upload it to Sentry: image (34) Sentry CLI Prints this output, not showing the set Release image (33)

lforst commented 11 months ago

Good ol rtfm 😄 https://www.npmjs.com/package/@sentry/vite-plugin#releasename. It's release.name not release.

HazAT commented 11 months ago

Oh boy - maybe we should at least print a warning or something. In the SDK it's just release that's a foot gun I would say.

lforst commented 11 months ago

It might be you being used to the v1 api of the webpack plugin which had the release option. We have types nowadays (even in JS) so I think printing warnings for wrong API usage is redundant.

HazAT commented 11 months ago

I am talking about how you set a release in the SDK, it's not an object there, it's a string. This is not a high prio item but a nice to have IMHO. I changed the title of the issue to make it obvious.