search

getsentry / sentry-javascript-bundler-plugins

JavaScript Bundler Plugins for Sentry
https://sentry.io
BSD 3-Clause "New" or "Revised" License
142 stars 37 forks source link

Allow newer versions of 3rd-party dependencies of `core` #496

Closed allanlewis closed 8 months ago

allanlewis commented 9 months ago

As per the sole commit:

Commit fba3468 pinned @babel/core as a dependency. In order to allow users to deduplicate the Babel stack, this commit amends the spec to allow newer versions as well. The same change is made to other 3rd-party production dependencies, except for unplugin 1 and magic-string 2 which apparently need to be pinned.

lforst commented 8 months ago

Hi, thanks for the PR. Can you limit the change to @babel/core. We have found that (some) of the other dependencies need to be pinned exactly, namely unplugin. Thank you!

allanlewis commented 8 months ago

Hi, thanks for the PR. Can you limit the change to @babel/core. We have found that (some) of the other dependencies need to be pinned exactly, namely unplugin. Thank you!

Sure, done!

allanlewis commented 8 months ago

Actually I've just reverted the unplugin change, surely the others can float?

lforst commented 8 months ago

Please let's also let magic-string pinned because it is very mission critical. The other ones we can try.

allanlewis commented 8 months ago

Please let's also let magic-string pinned because it is very mission critical.

Sure, will do.

allanlewis commented 8 months ago

I've reverted the change to magic-string.

allanlewis commented 8 months ago

CI is passing - is there anything else I need to do here?

lforst commented 8 months ago

Nope all good! Thank you!

allanlewis commented 8 months ago

@lforst Thanks! Can I expect this to make its way into a release sometime soon?