server runtime captureException event level undefined

Zih0 commented 5 months ago

Is there an existing issue for this?

[X] I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
[X] I have reviewed the documentation https://docs.sentry.io/
[X] I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/nextjs

SDK Version

7.100.0

Framework Version

nextjs 13.5.5

Link to Sentry event

No response

SDK Setup

No response

Steps to Reproduce

I found sentry/browser captureException sets the level of the event to error, but server runtime captureException don't set event level.

Expected Result

server runtime captureException event's level 'error'

Actual Result

https://codesandbox.io/p/devbox/ecstatic-merkle-8dklcm?file=%2Fsentry.server.config.js%3A8%2C96&workspaceId=0b6a93a6-ac89-4020-a035-0354bd4bb279

server side

client side

Lms24 commented 5 months ago

Hi @Zih0 thanks for writing in and for opening the PR! Before we review and merge it, can you explain what the consequences of the SDK not setting this default value are in the Sentry UI? Is there something missing? As far as I can tell, our Sentry backend sets a default level if it's not set by the SDK. However, if there's a discrepancy, I think we should fix it as you suggested.

Zih0 commented 5 months ago

@Lms24 Thank you for your comment! There was nothing wrong in Sentry UI. 🙂

I need to explain my situation first. I wanted to use beforeSend to handle the event if the level of the event is 'error' and 'fatal'. Then, I found that the event's level was coming in from the client side, while the event's level was not coming in from the server side. So I thought this was a bug, so I opened the issue and PR.

If you don't think this is a bug, you can close the issue. :)

Lms24 commented 5 months ago

Ahh I see, you're bringing up a good point. Let's try to align the behavior with the browser SDK. I just gave the PR a review. Looks good mostly, let's just fix the test then we can merge it.

getsentry / sentry-javascript