getsentry / sentry-javascript

Official Sentry SDKs for JavaScript
https://sentry.io
MIT License
7.98k stars 1.57k forks source link

Doublecheck GRPC Status to Span Status mapping #11195

Open lforst opened 7 months ago

lforst commented 7 months ago

Followup to https://github.com/getsentry/sentry-javascript/pull/11169

In the logic where we set a span status based on HTTP_STATUS_CODE or RPC_GRPC_STATUS code, there are two inconsistencies with the spec (https://opentelemetry.io/docs/specs/semconv/rpc/grpc/):

lforst commented 2 hours ago

Removed from v9 milestone because I don't think this is breaking.