Circular dependency when building with sentry sveltekit

sajaghori commented 1 month ago

Is there an existing issue for this?

[X] I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
[X] I have reviewed the documentation https://docs.sentry.io/
[X] I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/sveltekit

SDK Version

7.109.0

Framework Version

SvelteKit 2.5.5, Vite 5.2.8

Link to Sentry event

No response

SDK Setup

No response

Steps to Reproduce

Setup sentry sveltekit
Use node adapter
npm run build

Expected Result

No circular dependency

Actual Result

Using @sveltejs/adapter-node Circular dependency: node_modules/@sentry/core/esm/hub.js -> node_modules/@sentry/core/esm/scope.js -> node_modules/@sentry/core/esm/utils/applyScopeDataToEvent.js -> node_modules/@sentry/core/esm/tracing/dynamicSamplingContext.js -> node_modules/@sentry/core/esm/exports.js -> node_modules/@sentry/core/esm/hub.js Circular dependency: node_modules/@sentry/core/esm/scope.js -> node_modules/@sentry/core/esm/utils/applyScopeDataToEvent.js -> node_modules/@sentry/core/esm/tracing/dynamicSamplingContext.js -> node_modules/@sentry/core/esm/exports.js -> node_modules/@sentry/core/esm/utils/prepareEvent.js -> node_modules/@sentry/core/esm/scope.js Circular dependency: node_modules/@sentry/core/esm/utils/applyScopeDataToEvent.js -> node_modules/@sentry/core/esm/tracing/dynamicSamplingContext.js -> node_modules/@sentry/core/esm/exports.js -> node_modules/@sentry/core/esm/utils/prepareEvent.js -> node_modules/@sentry/core/esm/utils/applyScopeDataToEvent.js

Lms24 commented 1 month ago

Hey @sajaghori thanks for writing in! Yes, sadly there's a small circle in our import chain in the core package. We're resolving this in our new major version of the SDK (v8).

Does this block you at the moment? Are you by chance using a strict tsconfig of some kind (skiplibcheck 👀 ) that surfaces this issue? We'll fix this but just wondering if you can work around it in the meantime.

sajaghori commented 1 month ago

Hi @Lms24 thanks for the response! skiplibcheck does not work. I was looking for the reason why my vite dev server hangs sometimes. I can tell you that this circular dependency is not the root of cause. So feel free to close this or leave it open until you have v8 released.

Lms24 commented 1 month ago

Thanks for the update! The important thing is that you're not blocked by our SDK :) I'll leave this open for now until the circular dependency is resolved.

getsentry / sentry-javascript