getsentry / sentry-javascript

Official Sentry SDKs for JavaScript
https://sentry.io
MIT License
7.68k stars 1.49k forks source link

feat(nextjs): Add transaction name to scope of server component #11850

Closed s1gr1d closed 2 weeks ago

s1gr1d commented 3 weeks ago

ref https://github.com/getsentry/sentry-javascript/pull/11782

github-actions[bot] commented 3 weeks ago

size-limit report 📦

Path Size
@sentry/browser 21.64 KB (added)
@sentry/browser (incl. Tracing) 32.68 KB (added)
@sentry/browser (incl. Tracing, Replay) 68.03 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.43 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.07 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.27 KB (added)
@sentry/browser (incl. Feedback) 37.83 KB (added)
@sentry/browser (incl. sendFeedback) 26.43 KB (added)
@sentry/browser (incl. FeedbackAsync) 30.96 KB (added)
@sentry/react 24.33 KB (added)
@sentry/react (incl. Tracing) 35.64 KB (added)
@sentry/vue 25.47 KB (added)
@sentry/vue (incl. Tracing) 34.47 KB (added)
@sentry/svelte 21.77 KB (added)
CDN Bundle 24.02 KB (added)
CDN Bundle (incl. Tracing) 34.05 KB (added)
CDN Bundle (incl. Tracing, Replay) 67.72 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 73.05 KB (added)
CDN Bundle - uncompressed 70.62 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 100.98 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 210.59 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 224.22 KB (added)
@sentry/nextjs (client) 34.86 KB (added)
@sentry/sveltekit (client) 33.24 KB (added)
@sentry/node 138.47 KB (added)
mydea commented 3 weeks ago

Leaving this here for the future: E.g. this trace: https://sentry-javascript-sdks.sentry.io/performance/trace/24883c2fb15b4ea28ce5787afacc577b/ which comes from the canary tests (I think) shows the root cause, I believe. A bunch of "unrelated" (??) component renders are in the same trace, probably clobbering up the transactionName on the isolationScope, I guess... 🤔