Closed dorin-flooz closed 3 months ago
Hey, sorry about that - we are jumping on this as we speak.
in the meantime, to unblock you, can you create a file instrumentation.ts
and do this:
export async function register() {
if (process.env.NEXT_RUNTIME === 'nodejs') {
await import('./sentry.server.config');
}
if (process.env.NEXT_RUNTIME === 'edge') {
await import('./sentry.edge.config');
}
}
as outlined here https://docs.sentry.io/platforms/javascript/guides/nextjs/manual-setup/#create-initialization-config-files
@dorin-flooz Thanks for pointing this out! I updated the docs so they are in line with v8.
I guess the warning won't go away if you import the files like in the snippet @HazAT suggested. You have to delete the server.config
and edge.config
files. The contents of the files need to be added to the register()
function like this:
export async function register() {
if (process.env.NEXT_RUNTIME === 'nodejs') {
Sentry.init({
dsn: env.DSN
tracesSampleRate: 1.0,
});
}
if (process.env.NEXT_RUNTIME === 'edge') {
Sentry.init({
dsn: env.DSN
tracesSampleRate: 1.0,
});
}
}
hey @HazAT / @s1gr1d, thanks for the quick reply! What about versioned docs - any plans to have that implemented? We have postponed the upgrade to 8.0.0 due to the issues above, but if I understand correctly you have now overwritten https://docs.sentry.io/platforms/javascript/guides/nextjs to match the v8.0.0 API - in this case how would we access the v7.00-specific documentation until we upgrade?
@dorin-flooz we discussed this internally and probably going to work on them but since this is a bit of a larger project it will take a while but keep an eye out. Thanks for the feedback!
the doc concerning "telemetry" is still missing, no?
How to tackle To disable telemetry, set
options.telemetryto
false.
?
Thanks for the hints
Hello @kbsali, do you mean this section: https://docs.sentry.io/platforms/javascript/guides/astro/sourcemaps/#disabeling-telemetry-data-collection
@s1gr1d this is specific to Astro/vite apparently, we are running a nextjs project
@kbsali I am not 100% sure if we are talking about the same thing. You are right, it is currently not directly documented when the Next.js docs talk about extending the configuration. However, Astro and Next.js both use the vite-plugin and provide the same build options (you can find them here for vite and here for webpack). Is this what you were searching for? We can elaborate on this in the docs.
as far as I can tell
@sentry/nextjs
uses @sentry/webpack-plugin
@sentry/astro
uses @sentry/vite-plugin
I see options for webpack-plugin
but i'm not sure how to apply it in the context of @sentry/nextjs
Oh yes, Next.js is using webpack, but the options are the same. The options specifically for the webpack plugin are defined here. And the docs show you how to configure your build options (the link I posted in my previous comment).
I think, what you want to achieve is this in your next.config.ts
:
export default withSentryConfig(nextConfig, {
// your other options...
telemetry: false
});
Is this helping you? If yes, we will add this to the docs.
Adding the following to next.config.js solved my issue. Don't see this mentioned on the installation page but it is on the migrate from 7 to 8 docs
experimental: { instrumentationHook: true }
Thanks @briantweed, this will be added to the "Manual Setup" docs as well: https://github.com/getsentry/sentry-docs/pull/11140
Is there an existing issue for this?
How do you use Sentry?
Sentry Saas (sentry.io)
Which SDK are you using?
@sentry/nextjs
SDK Version
8.0.0
Framework Version
React latest
Link to Sentry event
No response
SDK Setup
No response
Steps to Reproduce
After upgrading to
@sentry/nextjs 8.0.0
, we get the following message in ouryarn next build
log:We tried following the documentation at https://docs.sentry.io/platforms/javascript/guides/nextjs to fix these issues, but it seems to be out of sync:
sentrySDKOptions
options.telemetry
telemetry
sentry.server.config.ts
- https://docs.sentry.io/platforms/javascript/guides/nextjs/configuration/integrations/#integration-usage-in-nextjsExpected Result
Actual Result
...