V8 causes error with Square payment form

JLuse commented 6 months ago

Is there an existing issue for this?

[X] I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
[X] I have reviewed the documentation https://docs.sentry.io/
[X] I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/react

SDK Version

8

Framework Version

No response

Link to Sentry event

No response

SDK Setup

No response

Steps to Reproduce

Reported by a customer who has mentioned the following: upgrading to Sentry JS V8 breaks the Square payment form (square.js) because they have this line in their code:

!!(t && t.__SENTRY__ && t.__SENTRY__.hub) && !qe(e).isOlderThan(Me) || Ve(e, new je),

And isOlderThan is no longer exposed in v8.

Example in support ticket - https://sentry.zendesk.com/agent/tickets/121772

Expected Result

SDK to work with Square forms

Actual Result

Error occurs

mydea commented 6 months ago

Hey, we are looking into ways to handle this better. This happens because of mismatching versions of the SDK being run at the same time, which is subject to break and lead to conflicts. ideally this can/should be avoided anyhow, but we'll make some adjustments to avoid breaking in such cases.

getsantry[bot] commented 4 months ago

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

ziemkowski commented 4 months ago

It appears that Square has published a workaround. I now have V8 and Square in production. So while this may well be an issue elsewhere, it no longer causes a JS error when using the Square Web Payments SDK.

For reference, the Square JS file is located here: https://web.squarecdn.com/v1/square.js

lforst commented 4 months ago

@ziemkowski that's good to know. Thanks for giving a heads up!

@JLuse is this issue also solved for you?

getsentry / sentry-javascript