search

getsentry / sentry-javascript

Official Sentry SDKs for JavaScript
https://sentry.io
MIT License
7.86k stars 1.55k forks source link

Use `@opentelemetry/instrumentation-undici` #12402

Open mydea opened 3 months ago

mydea commented 3 months ago

There is a somewhat new instrumentation now for node-fetch which we could use instead of the community one we are using today: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/instrumentation-undici

However, in order to maintain feature parity, we need to land this first: https://github.com/open-telemetry/opentelemetry-js-contrib/issues/2265

timfish commented 1 month ago
timfish commented 3 weeks ago

Once this is released I'll open a PR to migrate to the official instrumentation.

amakhrov commented 3 weeks ago

Will this replace the opentelemetry-instrumentation-fetch-node dependency? If so, it will be very helpful. The latter ships an older version of opentelemetry (due to a too-restrictive version range), and has generally been problematic in our app - we had to disable the respective integration in Sentry.init.

lforst commented 1 week ago

@amakhrov yes it will replace opentelemetry-instrumentation-fetch-node.