getsentry / sentry-javascript

Official Sentry SDKs for JavaScript
https://sentry.io
MIT License
7.98k stars 1.57k forks source link

`@sentry/node` `README.md` ESM details appear outdated #12890

Closed timfish closed 3 months ago

timfish commented 3 months ago

https://github.com/getsentry/sentry-javascript/tree/develop/packages/node#esm-support

node --experimental-loader=@opentelemetry/instrumentation/hook.mjs ./app.js

We should probably be telling users to use our own hook rather than the otel one, that way we can change the behaviour in the future without it being a breaking change

You'll need to install @opentelemetry/instrumentation in your app to ensure this works.

This isn't required. Has this been mistakenly kept from when this was the node-experimental package?

Maybe we can just remove all this ESM detail and point to these docs?

AbhiPrasad commented 3 months ago

These are def out of date, we should update!