fsevents from '@sentry/profiling-node' causes Github Action to fail

stolinski commented 3 weeks ago

Is there an existing issue for this?

[x] I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
[x] I have reviewed the documentation https://docs.sentry.io/
[x] I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/node

SDK Version

^8.36.0

Framework Version

Svelte ^5.1.9

Link to Sentry event

No response

Reproduction Example/SDK Setup

The Github action https://github.com/syntaxfm/website/actions/runs/11636308604

Steps to Reproduce

Run our test action. Removing '@sentry/profiling-node' will allow all tests to run and pass without issue.

Expected Result

Test ru

Actual Result

[WebServer]   node_modules/.pnpm/@sentry+sveltekit@8.36.0_@opentelemetry+api@1.9.0_@opentelemetry+core@1.27.0_@opentelemetry+i_igosr44v4ctingfomezncv7ima/node_modules/@sentry/sveltekit/build/cjs/vite/svelteConfig.js
[WebServer]     - file:///svelte.config.ts
[WebServer]   node_modules/.pnpm/@sentry+profiling-node@8.36.0/node_modules/@sentry/profiling-node/lib/cjs/index.js
[WebServer]     - /home/runner/work/website/website/node_modules/.pnpm/@sentry+profiling-node@8.36.0/node_modules/@sentry/profiling-node/lib/sentry_cpu_profiler-.node
[WebServer]   node_modules/.pnpm/@babel+core@7.26.0/node_modules/@babel/core/lib/config/files/module-types.js
[WebServer]     - @babel/preset-typescript
[WebServer]     - @babel/preset-typescript/package.json
[WebServer]   node_modules/.pnpm/chokidar@3.6.0/node_modules/chokidar/lib/fsevents-handler.js
[WebServer]     - fsevents
[WebServer] Segmentation fault (core dumped)

lforst commented 2 weeks ago

@JonasBa does this ring a bell?

My educated guess is that this is not really @sentry/profiling-node's fault, but rather that babel is trying to parse the .node profiling binary. (?)

I am assuming this is coming from this PR https://github.com/syntaxfm/website/pull/1884/files - I wonder if we can isolate this issue a bit more.

JonasBa commented 2 weeks ago

First time I see this @lforst. I'm sort of thinking that if that is the case, we would have seen this come up before already?

@stolinski I need to set some time aside to properly investigate this (there's a couple other issues that added up) so I'll probably get to this sometime by eow. Can you confirm if I can use the PR that @lforst link to try and reproduce the issue? I'm also curious if this can be reproduced locally with that PR?

stolinski commented 2 weeks ago

@lforst @JonasBa That's the correct PR, but really the failure happens in any PR. The playwright tests always run locally correctly, just on a GH Action does it fail like this.

If @sentry/profiling-node is removed, everything works as expected.

getsentry / sentry-javascript