Open lforst opened 1 week ago
We don't want to delete @sentry/types in the v9 major, just deprecate
I don't understand this statement.
@sentry/types
why not delete it from the repo? @sentry/types
what will be in it? Won't it diverge from what gets moved to core?@timfish this decision was pushed by @mydea. The idea is to limit breakage.
The theory is that too many people depend on the types package through docs and similar.
If we update types in core they will obv also be updated in the types package
Oh ok, I was missing this bit of context!
Description
We found that moving
@sentry/types
into@sentry/core
would clean up some architecture, docs, and prevent footguns like diverging package versions.This task involves:
@sentry/types
into@sentry/core
and exporting everything that was exported from types also from core (this also means we don't have to depend on@sentry/types
in@sentry/core
)@sentry/core
@sentry/types
from docs and replace with@sentry/core
@sentry/types
ATTENTION: Because of https://github.com/getsentry/sentry-javascript/issues/9840 which is also planned for v9, we do not want to export the
Client
type from@sentry/core
. The same goes for theScope
type. Instead, we want to exportClient
as an alias forBaseClient
as part of this task, and theScope
interface as we have it in@sentry/types
should not make it into@sentry/core
.We don't want to delete
@sentry/types
in the v9 major, just deprecate. The friction for deletion would likely be too high.