getsentry / sentry-javascript

Official Sentry SDKs for JavaScript
https://sentry.io
MIT License
8.01k stars 1.58k forks source link

[@sentry/angular] Update Angular to v19 #14386

Closed msrumon closed 1 day ago

msrumon commented 1 day ago

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/angular

SDK Version

8.39.0

Framework Version

Angular 19.0.0

Link to Sentry event

No response

Reproduction Example/SDK Setup

No response

Steps to Reproduce

Run npm i @sentry/angular in any Angular v19 project.

I'm happy to send PR if needed.

Expected Result

found 0 vulnerabilities

Actual Result

npm error Found: @angular/common@19.0.0
npm error node_modules/@angular/common
npm error   @angular/common@"^19.0.0" from the root project
npm error
npm error Could not resolve dependency:
npm error peer @angular/common@">= 14.x <= 18.x" from @sentry/angular@8.39.0
npm error node_modules/@sentry/angular
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
Lms24 commented 1 day ago

Hi, thanks for writing in! I'll take a look tomorrow and will update the peer dependencies asap (hopefully). In the meantime, you should be able to install the SDK using the --force argument

Lms24 commented 1 day ago

Hi, quick update: I bumped our peer dependencies and will release the changes soon

github-actions[bot] commented 4 hours ago

A PR closing this issue has just been released 🚀

This issue was referenced by PR #14398, which was included in the 8.40.0 release.