search

getsentry / sentry-javascript

Official Sentry SDKs for JavaScript
https://sentry.io
MIT License
8.02k stars 1.59k forks source link

ref: Refactor remaining usage of `request` to `normalizedRequest` #14401

Closed mydea closed 4 days ago

mydea commented 4 days ago

This includes exporting httpRequestToRequestEventData from @sentry/node, which we can reuse in a few places.

This also allows us to remove a bunch of stuff from remix, because actually we can just use winterCGRequestToRequestData instead of the custom implementation we have there. at least type wise, this should all work, let's see if any test complains...

Closes https://github.com/getsentry/sentry-javascript/issues/14298

github-actions[bot] commented 4 days ago

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.86 KB - -
@sentry/browser - with treeshaking flags 21.57 KB - -
@sentry/browser (incl. Tracing) 35.41 KB - -
@sentry/browser (incl. Tracing, Replay) 72.09 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.41 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 76.39 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 88.87 KB - -
@sentry/browser (incl. Feedback) 39.6 KB - -
@sentry/browser (incl. sendFeedback) 27.5 KB - -
@sentry/browser (incl. FeedbackAsync) 32.3 KB - -
@sentry/react 25.56 KB - -
@sentry/react (incl. Tracing) 38.27 KB - -
@sentry/vue 27.02 KB - -
@sentry/vue (incl. Tracing) 37.23 KB - -
@sentry/svelte 23.01 KB - -
CDN Bundle 24.04 KB - -
CDN Bundle (incl. Tracing) 36.99 KB - -
CDN Bundle (incl. Tracing, Replay) 71.69 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 77.05 KB - -
CDN Bundle - uncompressed 70.89 KB - -
CDN Bundle (incl. Tracing) - uncompressed 110.11 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 222.64 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 235.85 KB - -
@sentry/nextjs (client) 38.38 KB - -
@sentry/sveltekit (client) 35.91 KB - -
@sentry/node 134.46 KB +0.01% +13 B 🔺
@sentry/node - without tracing 96.3 KB +0.02% +18 B 🔺
@sentry/aws-serverless 106.54 KB +0.03% +25 B 🔺

View base workflow run

codecov[bot] commented 4 days ago

:x: 2 Tests Failed:

Tests completed Failed Passed Skipped
529 2 527 152
View the top 2 failed tests by shortest run time > > ```python > server-transactions.test.ts Sends server-side transactions to Sentry > ``` > >
Stack Traces | 0.061s run time > > > > > ```python > > server-transactions.test.ts:4:5 Sends server-side transactions to Sentry > > ``` > > 
server-errors.test.ts Sends a server-side exception to Sentry
Stack Traces | 0.092s run time > > ```python > server-errors.test.ts:4:5 Sends a server-side exception to Sentry > ```

To view more test analytics, go to the Test Analytics Dashboard Got feedback? Let us know on Github