search

getsentry / sentry-javascript

Official Sentry SDKs for JavaScript
https://sentry.io
MIT License
8.02k stars 1.59k forks source link

Make fs instrumentation follow semantic conventions #14527

Open AbhiPrasad opened 6 days ago

AbhiPrasad commented 6 days ago

Description

See https://opentelemetry.io/docs/specs/semconv/attributes-registry/file/

https://github.com/getsentry/sentry-javascript/blob/bdbdcc87b8816d439740395dcc551e5289e4431d/packages/node/src/integrations/fs.ts#L52 sets non namespaced attributes that don't follow conventions. We should see if we can set those as appropriate, and or contribute upstream to improve the conventions.

AbhiPrasad commented 5 days ago

It looks like we need to use https://opentelemetry.io/docs/specs/semconv/attributes-registry/error/

fs_error -> error.type