search

getsentry / sentry-javascript

Official Sentry SDKs for JavaScript
https://sentry.io
MIT License
7.78k stars 1.53k forks source link

Posting data through url is limited #191

Closed sekoyo closed 10 years ago

sekoyo commented 10 years ago

Hi,

We are having issues where posting data back through the url reaches the maximum size and fails.

I was wondering why you are not posting as data in the body which doesn't have such limitations? Is it because of compatibility? Would you be willing to provide an option to people who want to post data in the normal way which works for larger error reports? (Otherwise I will create a fork).

Thanks

src = globalServer + getAuthQueryString() + '&sentry_data=' + encodeURIComponent(JSON.stringify(data));

mattrobenolt commented 10 years ago

There were numerous tickets about this in the past that have been closed. There is simply more compatibility with doing a GET request instead of a POST and dealing with CORS and all that other fun stuff that lots of browsers don't handle.

BUT, moving forward, I'm going to be leveraging the new plugin infrastructure and provide pluggable transports. See #183. This will likely make it in for a 1.2 release when I get around to testing it and trying it out.

sekoyo commented 10 years ago

Great, thanks!