getsentry / sentry-javascript

Official Sentry SDKs for JavaScript
https://sentry.io
MIT License
7.97k stars 1.57k forks source link

Run loop deprecations at @sentry/ember #3911

Closed vlascik closed 3 years ago

vlascik commented 3 years ago

Package + Version

Version:

6.11.0

Description

Usage of run import e.g. in https://github.com/getsentry/sentry-javascript/blob/e46ff3e4c819962b045be9325fb1cedaa7178fb0/packages/ember/addon/instance-initializers/sentry-performance.ts#L3 which is then used to call runloop functions like run.scheduleOnce, is deprecated as of ember-source 3.27 (deprecated-run-loop-and-computed-dot-access, functions should be imported directly instead).

There may be more places this pattern is used, too.

nelstrom commented 3 years ago

Looks as though this issue has been addressed by #3915

k-fish commented 3 years ago

Ah, yeah, sorry, they got caught in the 4.0 forward-compatible work, I forgot to circle back to update this issue. Thanks for reporting 👍 .

Turbo87 commented 2 years ago
Bildschirmfoto 2021-11-11 um 10 27 35

These deprecation warnings are still being shown, because we're still accessing run.backburner in the getBackburner() function.

mileszim commented 2 years ago

@k-fish Using the latest and I am still seeing this. Code is still here https://github.com/getsentry/sentry-javascript/blob/cf10bf13bc113cf5f11b5e5a3b142504800f0a6c/packages/ember/addon/instance-initializers/sentry-performance.ts#L32-L33