Circular dependency

[marandaneto]

Is there an existing issue for this?

• [X] I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• [X] I have reviewed the documentation https://docs.sentry.io/
• [X] I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which package are you using?

@sentry/browser

SDK Version

6.17.9

Framework Version

No response

Link to Sentry event

No response

Steps to Reproduce

Run: madge . --extensions ts,tsx,js -c

More context https://github.com/getsentry/sentry-react-native/issues/2080

Expected Result

No circular dependency found!

Actual Result

✖ Found 6 circular dependencies!

1) packages/ember/addon/ember.d.ts 2) packages/nextjs/src/config/types.ts > packages/nextjs/src/config/webpack.ts 3) packages/types/src/event.ts > packages/types/src/scope.ts > packages/types/src/eventprocessor.ts 4) packages/types/src/span.ts > packages/types/src/transaction.ts 5) packages/types/src/client.ts > packages/types/src/integration.ts > packages/types/src/hub.ts 6) packages/types/src/integration.ts > packages/types/src/hub.ts

[AbhiPrasad]

Circular dependencies in types are not a problem as they still get compiled properly by the typescript compiler. This is why we don't run our circular dependency check on @sentry/types. Why did we raise this?

[marandaneto]

Because Metro warns for the React Native SDK and it's not possible to ignore it, yet.

[AbhiPrasad]

Even for types? The generated d.ts files should have no issues. There are no circular dependencies in the compiled dist assets (plain JS) that the SDK ships with. Is this metro warning for SDK development, or users asking about this?

[marandaneto]

@AbhiPrasad the linked issue in the issue description is opened by a user, that issue is linked to previous issues (even Sentry), and most of the time the circular dependencies are resolved by applying such fixes, if that solves the issue for good? no idea. Today, by installing Sentry in your RN App, you get a circular dependency warn.

[github-actions[bot]]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[marandaneto]

If the Circular dependency issues found by the madge tooling aren't a problem, feel free to close this issue.

[AbhiPrasad]

Yes, all of these are for types, which shouldn't affect the final emitted javascript assets, so we should be fine to close.