getsentry / sentry-javascript

Official Sentry SDKs for JavaScript
https://sentry.io
MIT License
7.7k stars 1.5k forks source link

[nextjs] Log drains support log source selection #5281

Closed smeubank closed 1 year ago

smeubank commented 1 year ago

Problem Statement

Recent changes in the NextJs framework from Vercel allow to select the log source selection.

Vercel Changelog: Log Drains now support log source selection

Solution Brainstorm

We should check if the NextJs SDK can be improved by this functionality, enriching events sent to Sentry

smeubank commented 1 year ago

we could auto-parse the logs for error/warning messages - but then they lose all the advantages of running an sdk in code (tags/contexts/stacktrace)

@AbhiPrasad

AbhiPrasad commented 1 year ago

It's important to note, we would require server-side Sentry changes to support becoming a logging sync.

Sentry is not a logging platform though, and users will lose a lot of the value from Sentry (as mentioned above - tags/contexts/stacktrace), if they just rely on incoming logs for errors. There's also probably a delay from Vercel -> Log Drain -> Sentry -> Sentry processing logs into Sentry events -> user (since the Vercel logging infra is an unknown from our side) that does not exist with the SDK sending events straight to Sentry after it catches errors.

Users will still also have to instrument their apps for performance monitoring, and ideally we do not want them to not use the SDK in favour of log sinks.

I wouldn't pursue this for now.

github-actions[bot] commented 1 year ago

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

danieljameswilliams commented 3 weeks ago

Has anything changed on this topic? - We would like our vercel hosting errors to logdrain into Sentry.

AbhiPrasad commented 1 week ago

@danieljameswilliams what specific kind of log sources are you looking to send to Sentry?