Mark transactions status to `ok` instead of none which leads to `unknown`

getsentry / sentry-javascript

Official Sentry SDKs for JavaScript

https://sentry.io

MIT License

7.79k stars 1.53k forks source link

Mark transactions status to `ok` instead of none which leads to `unknown` #5745

Open marandaneto opened 1 year ago

marandaneto commented 1 year ago

Problem Statement

All idle transactions are sent without a status. When transactions don't have a status, the frontend infers unknown unknown leads to confusion even though it's documented as a fine status.

Solution Brainstorm

Mark all transactions that are auto-finished and don't have a status overwritten by the user to ok. Mobile SDKs already do that.

AbhiPrasad commented 1 year ago

Technically this is a breaking change, but I think reasonable for us to do, and makes it much easier for users to understand what is happening.

Should we do this before a major bump?

AbhiPrasad commented 1 year ago

rel: https://github.com/getsentry/develop/issues/383

Based on a slack convo we've decided to include this change as part of the next major bump, since it's pretty high value.