search

getsentry / sentry-javascript

Official Sentry SDKs for JavaScript
https://sentry.io
MIT License
7.84k stars 1.54k forks source link

Remove `withSentry` in sentry-nextjs package #5893

Closed vladanpaunovic closed 4 months ago

vladanpaunovic commented 1 year ago

Problem Statement

As per https://github.com/getsentry/sentry-javascript/pull/5778 we are doing all route wrapping on our own and having withSentry function has a potential to cause confusion and frankly, it becomes a tech debt the moment we promote auto wrapping of nexjs API routes to default SDK behaviour.

Solution Brainstorm

⚠️ this is a breaking change. I propose we schedule this for our v8 release ⚠️

  1. Remove the withSentry from sentry-nextjs package
  2. Communicate breaking changes in v8 of the SDK.
lobsterkatie commented 1 year ago

Yup, this is the plan.

AbhiPrasad commented 4 months ago

Done with https://github.com/getsentry/sentry-javascript/pull/10549