search

getsentry / sentry-javascript

Official Sentry SDKs for JavaScript
https://sentry.io
MIT License
7.76k stars 1.52k forks source link

[Bug Report] Show better error message when feedback is blocked due to ad blockers #9371

Closed ryan953 closed 18 hours ago

ryan953 commented 8 months ago

I was using the Brave browser without any custom config to submit feedback and the feedback couldn't be submitted because of the built-in ad-blocking the browser has. "Shields" is their product name: https://brave.com/shields/

Repro steps:

Notice a few things around the screen: note screen shot
error message Image
Brave shields (at the browser url bar) Image
Blocked Network request Image
Network request details Image

I think tunneling is a very important feature to use in concert with Feedback. This is a case where no error is thrown, users see a cryptic error message a good case of a problem that feedback is designed to capture (so meta, feedback about feedback). Also, based on the specifics of the network 'blocked' maybe we can improve the error message users see.

To use Brave, and let data flow into sentry:

billyvg commented 8 months ago

Changed the title as tunneling will work when we switchover the API endpoint to use our normal ingestion pipeline.

bruno-garcia commented 3 months ago

Ad-blockers breaking the ability of you to reach out to your developer is a huge problem for developers and ad-blocker users.

For reference, here's a list of places where this came up:

farfalk commented 2 months ago

I think this should be at least documented on the user feedback docs until it's solved, because the feedback popup not working on my AdBlocked mobile browser during a random check on a commute (reminder to self, don't do that) gave me a heart hiccup 😅 fortunately I found this and tried again with no AdBlock, and It worked

mydea commented 2 months ago

@farfalk in v8 (currently out as 8.0.0-beta.3), we have an improved error message that points to ad-blockers as a possible cause (in the case we encounter a typical ad-blocker induced error). That should hopefully make this a bit clearer!

farfalk commented 2 months ago

@farfalk in v8 (currently out as 8.0.0-beta.3), we have an improved error message that points to ad-blockers as a possible cause (in the case we encounter a typical ad-blocker induced error). That should hopefully make this a bit clearer!

Thanks, nice to know! Is there any kind of already known non-beta release window?

mydea commented 2 months ago

@farfalk in v8 (currently out as 8.0.0-beta.3), we have an improved error message that points to ad-blockers as a possible cause (in the case we encounter a typical ad-blocker induced error). That should hopefully make this a bit clearer!

Thanks, nice to know! Is there any kind of already known non-beta release window?

Hopefully soon ;) It depends on if any issues arise during the beta phase. We'll keep you posted!

c298lee commented 18 hours ago

Fixed with https://github.com/getsentry/sentry-javascript/pull/12647