getsentry / sentry-jira

A Plugin for sentry that lets you create JIRA issues
Other
95 stars 32 forks source link

Jira incorrectly reports auth not configured #15

Closed dcramer closed 12 years ago

dcramer commented 12 years ago

The not_configured template render line should be:

            return self.render(self.not_configured_template, {
                'title': self.get_title(),
                'project': group.project,
                'has_auth_configured': has_auth_configured,
                'required_auth_settings': required_auth_settings,
            })

We should probably make this easier to extend. Open to ideas

thurloat commented 12 years ago

thanks for picking this one out, It kills me to override the view function like that and have to update my codes each time you make changes to it.

I think the most useful extension points for me would be a process_form method called out from the base view for overriding saves / how validations are displayed for custom fields, and some way way to hook up xhr calls within the plugin (not sure what that looks like?)