Closed snigdhas closed 3 months ago
versions in use:
The following repositories use one of the schemas you are editing. It is recommended to roll out schema changes in small PRs, meaning that if those used versions lag behind the latest, it is probably best to update those services before rolling out your change.
pip:sentry-kafka-schemas==0.1.90
rust:sentry-kafka-schemas==0.1.90
pip:sentry-kafka-schemas==0.1.90
latest version: 0.1.90
⚠️ This PR contains breaking changes. Normally you should avoid that and make your consumer backwards-compatible (meaning that updated consumers can still accept old messages). There are a few exceptions:
If consumers already require these invariants in practice, and you're just adjusting the JSON schema to reality, ignore this warning.
If you know what you are doing, this change could potentially be rolled out to producers first, but that's not a flow we support.
@snigdhas Why is this a breaking change? Can you look into that failure?
@evanh it's technically breaking change because additionalProperties
was set to true before, and thus there may have been messages with this key and a different type earlier that were considered valid. But if you know were never sending first_release_id
as something else before, you're fine.
But if you know were never sending first_release_id as something else before, you're fine
Yep, brand new column on the GroupAttributes table (added here) and hasn't been included in the messages.
the json-schema-diff
job is set up to fail on breaking changes as a warning but is not required, feel free to merge through that particular failure
Update the schema to handle the new
group_first_release_id
column added to GroupAttributes in https://github.com/getsentry/snuba/pull/5986