The following repositories use one of the schemas you are editing. It is recommended to roll out schema changes in small PRs, meaning that if those used versions lag behind the latest, it is probably best to update those services before rolling out your change.
changes considered breaking
**schemas/ingest-metrics.v1.schema.json**
- Added a new property, but the consumer has been ignoring additional properties so far. This is probably still fine, but please double-check that the producer does not already send this property with a different type in practice than you defined in this schema.
```
{"path": "", "change": {"PropertyAdd": {"lhs_additional_properties": true, "added": "sampling_weight"}}}
```
**schemas/snuba-generic-metrics.v1.schema.json**
- Added a new property, but the consumer has been ignoring additional properties so far. This is probably still fine, but please double-check that the producer does not already send this property with a different type in practice than you defined in this schema.
```
{"path": "", "change": {"PropertyAdd": {"lhs_additional_properties": true, "added": "sampling_weight"}}}
```
benign changes
**schemas/ingest-metrics.v1.schema.json**
- Removed a property `sample_weight` from ``, but it is still accepted via `additionalProperties=true`
```
{"path": "", "change": {"PropertyRemove": {"lhs_additional_properties": true, "removed": "sample_weight"}}}
```
**schemas/snuba-generic-metrics.v1.schema.json**
- Removed a property `sample_weight` from ``, but it is still accepted via `additionalProperties=true`
```
{"path": "", "change": {"PropertyRemove": {"lhs_additional_properties": true, "removed": "sample_weight"}}}
```
⚠️ This PR contains breaking changes. Normally you should avoid that and make
your consumer backwards-compatible (meaning that updated consumers can still
accept old messages). There are a few exceptions:
If consumers already require these invariants in practice, and you're
just adjusting the JSON schema to reality, ignore this warning.
If you know what you are doing, this change could potentially be rolled out
to producers first, but that's not a flow we support.
versions in use:
The following repositories use one of the schemas you are editing. It is recommended to roll out schema changes in small PRs, meaning that if those used versions lag behind the latest, it is probably best to update those services before rolling out your change.
pip:sentry-kafka-schemas==0.1.103(upgrade)rust:sentry-kafka-schemas==0.1.103(upgrade)pip:sentry-kafka-schemas==0.1.105rust:sentry-kafka-schemas==0.1.86(upgrade)latest version: 0.1.105
changes considered breaking
**schemas/ingest-metrics.v1.schema.json** - Added a new property, but the consumer has been ignoring additional properties so far. This is probably still fine, but please double-check that the producer does not already send this property with a different type in practice than you defined in this schema. ``` {"path": "", "change": {"PropertyAdd": {"lhs_additional_properties": true, "added": "sampling_weight"}}} ``` **schemas/snuba-generic-metrics.v1.schema.json** - Added a new property, but the consumer has been ignoring additional properties so far. This is probably still fine, but please double-check that the producer does not already send this property with a different type in practice than you defined in this schema. ``` {"path": "", "change": {"PropertyAdd": {"lhs_additional_properties": true, "added": "sampling_weight"}}} ```benign changes
**schemas/ingest-metrics.v1.schema.json** - Removed a property `sample_weight` from ``, but it is still accepted via `additionalProperties=true` ``` {"path": "", "change": {"PropertyRemove": {"lhs_additional_properties": true, "removed": "sample_weight"}}} ``` **schemas/snuba-generic-metrics.v1.schema.json** - Removed a property `sample_weight` from ``, but it is still accepted via `additionalProperties=true` ``` {"path": "", "change": {"PropertyRemove": {"lhs_additional_properties": true, "removed": "sample_weight"}}} ```⚠️ This PR contains breaking changes. Normally you should avoid that and make your consumer backwards-compatible (meaning that updated consumers can still accept old messages). There are a few exceptions:
If consumers already require these invariants in practice, and you're just adjusting the JSON schema to reality, ignore this warning.
If you know what you are doing, this change could potentially be rolled out to producers first, but that's not a flow we support.