getsentry / sentry-kubernetes

Kubernetes event reporter for Sentry
Apache License 2.0
458 stars 64 forks source link

fix: correct fingerprinting and common enhancer call #78

Closed Jiahui-Zhang-20 closed 8 months ago

Jiahui-Zhang-20 commented 8 months ago

Issues Addressed:

  1. If the involved object has owners, then the fingerprint now only includes the owners' kind and name so all objects with the same root owner are grouped. For example, if the involved object is a pod and it is owned by a deployment, the fingerprint will not include Pod or <pod_name> but instead Deployment and <deployment_name>.
  2. Currently, the general enhancer only supports a subset of workload resource objects (Pod, Job, CronJob, ReplicaSet, Deployment) but not others (e.g. Node, Service, StatefulSet). We now call the common enhancer on the involved object regardless of whether the general enhancer supports that object. This way, the event message can at least be enhanced if needed.
codecov[bot] commented 8 months ago

Codecov Report

Attention: 50 lines in your changes are missing coverage. Please review.

Comparison is base (ea40479) 25.59% compared to head (4f9106e) 27.19%.

Files Patch % Lines
enhancers.go 54.54% 45 Missing and 5 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #78 +/- ## ========================================== + Coverage 25.59% 27.19% +1.59% ========================================== Files 22 22 Lines 1633 1651 +18 ========================================== + Hits 418 449 +31 + Misses 1175 1157 -18 - Partials 40 45 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.