search

getsentry / sentry-kubernetes

Kubernetes event reporter for Sentry
Apache License 2.0
458 stars 64 forks source link

feat: enable multiarch build #88

Closed nohant closed 5 months ago

nohant commented 6 months ago

Hello!

by adding the architecture in the GOARCH variable it should be compile faster and work better for the https://github.com/getsentry/sentry-kubernetes/issues/71

I didn't update the version of the various actions because maybe there is a motive for them to be that specific and I don't know.

Locally i tried TARGETPLATFORM and TARGETARCH

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 31.64%. Comparing base (55429ee) to head (8802851).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #88 +/- ## ======================================= Coverage 31.64% 31.64% ======================================= Files 22 22 Lines 1640 1640 ======================================= Hits 519 519 Misses 1070 1070 Partials 51 51 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nohant commented 5 months ago

yep I was undecided to which use of the two, better if it works with ARCH

tonyo commented 5 months ago

Looks like ARG is not needed; also added TARGETPLATFORM, should be good now.

nohant commented 5 months ago

super good work, thank you mate