Wrong MIME type is sent for attachment

getsentry / sentry-native

Sentry SDK for C, C++ and native applications.

MIT License

405 stars 170 forks source link

Wrong MIME type is sent for attachment #1031

Closed dalnoki closed 2 months ago

dalnoki commented 3 months ago

Description

The SDK set the 'application/octet-stream' MIME Type for a .txt file, please see details in the JIRA ticket: https://getsentry.atlassian.net/browse/FEEDBACK-2259

When does the problem happen

[ ] During build
[ ] During run-time
[ ] When capturing a hard crash

Environment

OS: [e.g. Windows 10, 64-bit]
Compiler: [e.g. MSVC 19]
CMake version and config: [e.g. 3.17.2, SENTRY_BACKEND=inproc]

Steps To Reproduce

Log output

kahest commented 3 months ago

supervacuus commented 3 months ago

The web-ui auto-detects the MIME type of attachments when no content-type header is sent with the attachment, which is why we don't do any MIME detection in the SDK.

Since version 0.7.2, user-supplied attachments should not be sent with a content-type header when using crashpad (i.e., also not application/octet-stream). We never sent a content type for all other backends.

getsantry[bot] commented 2 months ago

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀