search

getsentry / sentry-native

Sentry SDK for C, C++ and native applications.
MIT License
403 stars 170 forks source link

[NDK] Add loadNativeLibraries method to allow pre-loading .so files #1082

Closed markushi closed 6 days ago

markushi commented 6 days ago

sentry-java 7.x loads the .so libraries using a background thread, see https://github.com/getsentry/sentry-java/pull/3670

Instead of porting this behaviour 1:1 to sentry-native, I'm proposing a new .loadNativeLibraries() method, allowing you to pre-load the libraries if necessary. It's up to the consumer, like sentry-java 8.x to use this method, and e.g. call it on a background thread.

This is a change in behaviour, as the .so files no longer get loaded during class init.

github-actions[bot] commented 6 days ago
Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by :no_entry_sign: dangerJS against b5d3b8325d7da759297afbca91c638e8f03b119e

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.34%. Comparing base (d8230a8) to head (b5d3b83). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1082 +/- ## ========================================== - Coverage 82.40% 82.34% -0.07% ========================================== Files 53 53 Lines 7752 7752 Branches 1216 1216 ========================================== - Hits 6388 6383 -5 - Misses 1252 1257 +5 Partials 112 112 ```

🚨 Try these New Features: