search

getsentry / sentry-native

Sentry SDK for C, C++ and native applications.
MIT License
405 stars 170 forks source link

fix: build zlib for mingw ci #964

Closed supervacuus closed 8 months ago

supervacuus commented 8 months ago

The mingw CI currently breaks, because it relied on a zlib packaged with StrawberryPerl which can no longer be found by CMake. It would generally be a good idea that our builds are independent of GHA image packages (except if there is a zlib package, of course).

skip-changelog

supervacuus commented 8 months ago

This currently blocks two other PRs, #963 and #954, which can be rebased after we merge this.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.74%. Comparing base (2ae5de6) to head (24f9108).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #964 +/- ## ========================================== + Coverage 82.68% 82.74% +0.05% ========================================== Files 53 53 Lines 7376 7376 Branches 1186 1186 ========================================== + Hits 6099 6103 +4 + Misses 1169 1164 -5 - Partials 108 109 +1 ```