search

getsentry / sentry-netlify-build-plugin

The Sentry Netlify build plugin automatically notifies Sentry of new releases being deployed to your site.
Apache License 2.0
46 stars 17 forks source link

chore(deps): Switch to yarn #71

Closed lobsterkatie closed 1 year ago

lobsterkatie commented 1 year ago

This switches to using yarn rather than npm for managing dependencies, since that's the standard practice at Sentry (see our repos for the main sentry app, our JS SDK, the webpack plugin, etc.).

Ref: WOR-2817

scttcper commented 1 year ago

we should probably get off node 10 and cache directly with the newer setup-node action instead of our own manual cache https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#caching-packages-data

lobsterkatie commented 1 year ago

we should probably get off node 10 and cache directly with the newer setup-node action instead of our own manual cache actions/setup-node@main/docs/advanced-usage.md#caching-packages-data

Agreed. One change at a time, though. 🙂

[EDIT]: I did need to bump node, just because yarn is stricter in checking current node version vs dependency node version requirements than npm is, and netlify-cli wants at least node 12. I went to 16 for now just because it'll take a while for that to get out of date, and given what we're doing in that GHA workflow I don't honestly think it matters what node we're using.