search

getsentry / sentry-php

The official PHP SDK for Sentry (sentry.io)
https://sentry.io
MIT License
1.83k stars 451 forks source link

PHP8.4 compat #1744

Closed staabm closed 3 weeks ago

staabm commented 4 months ago

How do you use Sentry?

Sentry SaaS (sentry.io)

SDK version

4.7.0

Steps to reproduce

I think this line needs a change for PHP 8.4 compat - related to https://github.com/php/php-src/pull/13550

see analog symfony change: https://github.com/symfony/symfony/pull/54614

Expected result

n/a

Actual result

n/a

cleptric commented 4 months ago

Thanks, we'll tackle this closer to the PHP 8.4 release in November.

stayallive commented 3 weeks ago

I have started a PR and moved all your comments to #1760 to track.

Thanks for pointing this change out! If you have any other concerns feel free to comment on the PR!