Closed mindplay-dk closed 6 years ago
Thank you a lot for providing this! It's an invaluable way to help us. We will investigate this, but we probably have some changes to apply to the branch. We'll see...
First of all, thanks for the feedback, I think you're the first one ever trying the 2.0
branch and your feedback is welcome and highly appreciated. As said by @Jean85 we might have some BC changes incoming starting from next week, but we're not sure yet so keep an eye on the repository if you want to work with this version as its API should be almost complete and pretty stable now but it may not be in the future
I'm not sure why that's happening - maybe a bug in the previous middleware?
The bug is not in the previous middleware but in the SanitizeHttpHeadersMiddleware
middleware itself. In fact the event payload contains an array representing the request, but the middleware receives a PSR-7 object that they can use in whichever way they want to retrieve data and fill the event information. Unfortunately in some refactoring I probably missed that I've called a local variable with the same name as the argument parameter $request
, which means that it gets overridden and then passed to the next middleware causing the bug
The fix is pretty simple, if you want we would be glad to accept a PR that fixes the issue
I'll do the PR!
This should be fixed. If you're still trying the 2.0 branch updating should make it work. Please let us know if the problem still occurs, but please note that BC changes are coming and so using this version now could mean a lot of work to keep it up with the new developments until the API reach a stable point
Parse error: syntax error, unexpected '?', expecting variable (T_VARIABLE) in /home/vagrant/vendor/zendframework/zend-diactoros/src/functions/marshal_uri_from_sapi.php on line 83
Getting the above error when I initialize senry fucntion.
This error does not belongs to this issue. Please open an issue in zendframework/zend-diactoros
or check that your PHP version is at least 7.1
Just for testing, I've placed a deliberate
throw new RuntimeException('whoa')
somewhere in my code, as I'm attempting to submit my first event viaSentry\Client::captureException()
:Note that I'm not using
ErrorHandler
- we have an error-handler in our stack already, so I'm attempting to use just theSentry\Client
, which seems like something you had more in mind with version 2 than with version 1. (?)I'm getting the following inner/outer exceptions:
The tail of the stack-trace looks like this:
Looks like
$request
is in deed an array and not a PSR Request:I'm not sure why that's happening - maybe a bug in the previous middleware?
I'm doing no additional configuration of the client beyond just
["dsn" => "..."]
.Here's a dump of all installed package versions:
Anything else I can do or provide to help fix this?