search

getsentry / sentry-python

The official Python SDK for Sentry.io
https://sentry.io/for/python/
MIT License
1.93k stars 510 forks source link

CloudResourceContextIntegration freezing in ECS Container #2376

Open jensenbox opened 1 year ago

jensenbox commented 1 year ago

How do you use Sentry?

Sentry Saas (sentry.io)

Version

1.31.0

Steps to Reproduce

Configure the CloudResourceContextIntegration without any parameters but run in an ECS container on AWS - which is running on EC2 hardware.

My suggestion is to either make the IMDS address configurable or do some detection to see if you are on ECS. There is an IMDS for ECS you could use.

At the very least make the http have a timeout so that things are not totally locked up.

Expected Result

Not freeze

Actual Result

Infinite freeze at https://github.com/getsentry/sentry-python/blob/master/sentry_sdk/integrations/cloud_resource_context.py#L74

antonpirker commented 1 year ago

Hey @jensenbox ! Thanks for reporting this. I guess I never tested it on ECS. But it seams like a not-so-big fix. (regardless the request should not freece in the first place but just time out at some point...)