search

getsentry / sentry-python

The official Python SDK for Sentry.io
https://sentry.io/for/python/
MIT License
1.93k stars 509 forks source link

Update openai.py #3807

Closed sourceful-rob closed 2 days ago

sourceful-rob commented 2 days ago

Update the arguments in the start_span function. pecifically, changing the deprecated "description" to "name". This was causing a deprecation warning when running tests.

Thank you for contributing to sentry-python! Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.

sentrivana commented 2 days ago

Thank you @sourceful-rob for catching this!

codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.87%. Comparing base (d894fc2) to head (f22b59f). Report is 1 commits behind head on master.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3807 +/- ## ========================================== - Coverage 79.89% 79.87% -0.02% ========================================== Files 137 137 Lines 15371 15371 Branches 2608 2608 ========================================== - Hits 12281 12278 -3 - Misses 2221 2223 +2 - Partials 869 870 +1 ``` | [Files with missing lines](https://app.codecov.io/gh/getsentry/sentry-python/pull/3807?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [sentry\_sdk/integrations/openai.py](https://app.codecov.io/gh/getsentry/sentry-python/pull/3807?src=pr&el=tree&filepath=sentry_sdk%2Fintegrations%2Fopenai.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c2VudHJ5X3Nkay9pbnRlZ3JhdGlvbnMvb3BlbmFpLnB5) | `80.15% <ø> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry-python/pull/3807/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)