Open rcoup opened 4 years ago
This issue has gone three weeks without activity. In another week, I will close it.
But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog
or Status: In Progress
, I will leave it alone ... forever!
"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀
Would it be worth exposing getter properties/methods, add
scope.merge_*()
methods (which calldict.update()
), addmerge=True|False
parameters toset_user()
&set_context()
, or something else equivalent?
@sl0thentr0py I can potentially do a PR for this, but need some direction on which option is preferred
Hi @rcoup, user facing API changes need to be discussed internally first. A lot of folks are on vacation right now. I'll try to get back to you with more info next week.
Note for later: https://develop.sentry.dev/sdk/unified-api/#scope We're currently not doing what the documentation states, so we should probably change this in the next major.
Use case:
Authorization
header), and callscope.set_user({'http-username': 'bob'})
scope.set_user({'email': 'test@example.com'})
. Lets assume the request/headers aren't available at that point to re-retrievehttp-username
.{'email': 'test@example.com'}
)scope.set_context('section', {'some': 'value'})
)AFAICT there isn't even a way to get the current user/contexts out again in order to manually merge them except via internals (
scope._user
/scope._contexts['a_section']
). The framework integrations all seem to append to the user data, but that seems to happen much later in the processing.Would it be worth exposing getter properties/methods, add
scope.merge_*()
methods (which calldict.update()
), addmerge=True|False
parameters toset_user()
&set_context()
, or something else equivalent?