getsentry / sentry-react-native

Official Sentry SDK for React Native
https://sentry.io
MIT License
1.57k stars 333 forks source link

Document and test ErrorBoundary #1775

Open bruno-garcia opened 3 years ago

bruno-garcia commented 3 years ago

Perhaps some of the JS docs could be moved to an include and reused. But here we need to document why it's needed vs bubbling to the unhandled exception integration. And when/how the white screen rendering happens.

We have a user reported issue that the fallback isnt' working on React Native. Consider adding this test case to e2e.

github-actions[bot] commented 2 years ago

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

marandaneto commented 2 years ago

@bruno-garcia can you link where this is already documented for JS?

I guess its https://docs.sentry.io/platforms/javascript/guides/react/components/errorboundary/ just to confirm, is it a React thing only?

marandaneto commented 2 years ago

ping @bruno-garcia

bruno-garcia commented 2 years ago

ping @bruno-garcia

Sorry, I don't keep up with GH notifications anymore. Please drop me a link via DM if I'm blocking?

@bruno-garcia can you link where this is already documented for JS?

https://github.com/getsentry/sentry-docs/search?q=ErrorBoundary

I guess its docs.sentry.io/platforms/javascript/guides/react/components/errorboundary just to confirm, is it a React thing only?

Yes

wouterds commented 1 year ago

Is ErrorBoundary (import { ErrorBoundary } from '@sentry/react-native') supposed to be used & working?

I can't find docs about it but the export from @sentry/react-native definitely exists.

krystofwoldrich commented 1 year ago

Hi, the ErrorBoundary should work the same as in Browser React.

Here are docs for it: https://docs.sentry.io/platforms/javascript/guides/react/features/error-boundary/